Peer Testing

Testing done via https://www.wiki.ed.ac.uk/display/insite/PUREINT+UPM+interface+and+refresh+process+documentation

 

As per the above this was testing the transition to the new data model.

 

Areas Tested - No JIRAs issued

General 

  • Proof that old and new process produce similar outputs: Developer undertook audit scripts which measure changes and variance in the processes.  These provided assurance that the processes had been followed
  • Performance: discussed the timings and outputs of the new process, both tester and developer felt these were adequate
  • ANSI SQL: the process is written using ANSI sql to provide clarity and to aid any further development as the process may require changes over the next period 
  • Transaction and Processing state: The developer and the tester agreed to implement specific commits and rollbacks in the process, primarily to manage the amount of rollback but there were no specific concerns but both felt it would be helpful to diagnose later issues if they occurred
  • Execute Immediate: discussed use of Execute Immediate and both felt it was a sensible use
  • Exceptions - Developer added some further exception handling into the main body so any transactional errors roll up to the main body - this should not be neccessary but was felt it provided assurance if there was an error

Specific stylistic but non functional areas 

  • creating constants for variables: some of the variables would potentially be better served as constants i.e. 'R' values etc
  • Ensure that the table prefixes are used in all tables (database links excluded)
  • Discussion around clarity vs brevity: In some places the code is being explicit  about its intent  but could possibly be condensed both the tester and the developer felt these could be addressed on a case by case basis but currently the clarity provided helped for understanding of the process and the conversion of the data model

 

Procedures that could be refactored:

  • stage_project_data
  • stage_award_financial_fundings

Project Info

Project
Pure Upgrade to new Project Model
Code
RES069
Programme
Research Information Systems (RIS)
Management Office
ISG PMO
Project Manager
Karen Stirling
Project Sponsor
Dominic Tate
Current Stage
Close
Status
Closed
Project Classification
Run
Start Date
21-Aug-2017
Planning Date
16-Mar-2018
Delivery Date
22-Apr-2019
Close Date
20-May-2019
Programme Priority
8
Overall Priority
Highest
Category
Compliance